[PATCH] D11441: Generating available_externally vtables for classes without inline virtual functions

David Majnemer david.majnemer at gmail.com
Thu Jul 23 11:19:21 PDT 2015


majnemer added inline comments.

================
Comment at: lib/CodeGen/CGVTables.cpp:835
@@ -821,2 +834,3 @@
                                                    const CXXRecordDecl *RD) {
-  return !CGM.getVTables().isVTableExternal(RD);
+  // If vtable is internal then it has to be done
+  if (!CGM.getVTables().isVTableExternal(RD))
----------------
Odd.  clang-format puts the return on its own line.


http://reviews.llvm.org/D11441







More information about the cfe-commits mailing list