r240376 - Eliminate "enumeration value not handled in switch" warnings

[Nico Weber]

Yes, which is probably why this was an if, not a switch (?)
On Jun 23, 2015 3:13 AM, "Rafael Espíndola" <rafael.espindola at gmail.com>
wrote:

> there are 37 values and only 2 are used in here :-)
>
> On 23 June 2015 at 01:22, Nico Weber <thakis at chromium.org> wrote:
> > I think we prefer listing all enumeration values in switches (iirc
> there's
> > even some other warning that checks that).
> >
> > On Jun 22, 2015 9:25 PM, "Douglas Katzman" <dougk at google.com> wrote:
> >>
> >> Author: dougk
> >> Date: Mon Jun 22 23:20:44 2015
> >> New Revision: 240376
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=240376&view=rev
> >> Log:
> >> Eliminate "enumeration value not handled in switch" warnings
> >>
> >> (Caused by r240370)
> >>
> >> Modified:
> >>     cfe/trunk/lib/Driver/ToolChains.cpp
> >>
> >> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> >> URL:
> >>
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=240376&r1=240375&r2=240376&view=diff
> >>
> >>
> ==============================================================================
> >> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)
> >> +++ cfe/trunk/lib/Driver/ToolChains.cpp Mon Jun 22 23:20:44 2015
> >> @@ -2455,6 +2455,8 @@ void NaCl_TC::AddClangCXXStdlibIncludeAr
> >>      llvm::sys::path::append(P, "x86_64-nacl/include/c++/v1");
> >>      addSystemInclude(DriverArgs, CC1Args, P.str());
> >>      break;
> >> +  default:
> >> +    break;
> >>    }
> >>  }
> >>
> >>
> >>
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150623/69745b43/attachment.html>