<p dir="ltr">Yes, which is probably why this was an if, not a switch (?)</p>
<div class="gmail_quote">On Jun 23, 2015 3:13 AM, "Rafael Espíndola" <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">there are 37 values and only 2 are used in here :-)<br>
<br>
On 23 June 2015 at 01:22, Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:<br>
> I think we prefer listing all enumeration values in switches (iirc there's<br>
> even some other warning that checks that).<br>
><br>
> On Jun 22, 2015 9:25 PM, "Douglas Katzman" <<a href="mailto:dougk@google.com">dougk@google.com</a>> wrote:<br>
>><br>
>> Author: dougk<br>
>> Date: Mon Jun 22 23:20:44 2015<br>
>> New Revision: 240376<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D240376-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Xrv_bCbCNbFCEBn7lVjnkYQhhlg23qwEOrgvvItkOmc&s=f9Mffyp-XDgWNrWq9UkmTlxD8AKn-Sd7kdtqMOhwKIA&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=240376&view=rev</a><br>
>> Log:<br>
>> Eliminate "enumeration value not handled in switch" warnings<br>
>><br>
>> (Caused by r240370)<br>
>><br>
>> Modified:<br>
>>     cfe/trunk/lib/Driver/ToolChains.cpp<br>
>><br>
>> Modified: cfe/trunk/lib/Driver/ToolChains.cpp<br>
>> URL:<br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_cfe_trunk_lib_Driver_ToolChains.cpp-3Frev-3D240376-26r1-3D240375-26r2-3D240376-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=Xrv_bCbCNbFCEBn7lVjnkYQhhlg23qwEOrgvvItkOmc&s=fn6UvK9SkAnZmltF-pNMuTWY69_f6WoYOh-XUEn20cw&e=" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=240376&r1=240375&r2=240376&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- cfe/trunk/lib/Driver/ToolChains.cpp (original)<br>
>> +++ cfe/trunk/lib/Driver/ToolChains.cpp Mon Jun 22 23:20:44 2015<br>
>> @@ -2455,6 +2455,8 @@ void NaCl_TC::AddClangCXXStdlibIncludeAr<br>
>>      llvm::sys::path::append(P, "x86_64-nacl/include/c++/v1");<br>
>>      addSystemInclude(DriverArgs, CC1Args, P.str());<br>
>>      break;<br>
>> +  default:<br>
>> +    break;<br>
>>    }<br>
>>  }<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
><br>
</blockquote></div>