[PATCH] Refactor: Simplify boolean conditional return statements in lib/Sema

David Blaikie dblaikie at gmail.com
Tue May 26 16:10:07 PDT 2015


On Tue, May 26, 2015 at 4:06 PM, Richard <legalize at xmission.com> wrote:

> In http://reviews.llvm.org/D10019#178722, @dblaikie wrote:
>
> > We should come to some conclusion about these chained return cases -
> they seem fairly benign/not buggy/not worth changing.
>
>
> Ah... I see what you mean.  So like the other case where it was something
> like `if (expr) var = true; else if (expr2) var = true; else if (expr3) var
> = true; else var = false;`, you'd like the option of disabling this check
> when it is a series of chained return statements?
>

Yeah, they seem equivalent


> That's great feedback and is something I can do to enhance the check.
>
>
> http://reviews.llvm.org/D10019
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150526/25ed8af7/attachment.html>


More information about the cfe-commits mailing list