[PATCH] Refactor: Simplify boolean conditional return statements in lib/Sema

Richard legalize at xmission.com
Tue May 26 16:06:15 PDT 2015


In http://reviews.llvm.org/D10019#178722, @dblaikie wrote:

> We should come to some conclusion about these chained return cases - they seem fairly benign/not buggy/not worth changing.


Ah... I see what you mean.  So like the other case where it was something like `if (expr) var = true; else if (expr2) var = true; else if (expr3) var = true; else var = false;`, you'd like the option of disabling this check when it is a series of chained return statements?

That's great feedback and is something I can do to enhance the check.


http://reviews.llvm.org/D10019

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list