r238200 - [MIPS] fix extension of integer types (function calls)

Alexander Kornienko alexfh at google.com
Tue May 26 08:49:41 PDT 2015


On Tue, May 26, 2015 at 5:20 PM, H.J. Lu <hjl.tools at gmail.com> wrote:

> On Tue, May 26, 2015 at 6:30 AM, Petar Jovanovic
> <petar.jovanovic at imgtec.com> wrote:
> > Author: petarj
> > Date: Tue May 26 08:30:54 2015
> > New Revision: 238200
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=238200&view=rev
> > Log:
> > [MIPS] fix extension of integer types (function calls)
> >
> > On MIPS unsigned int type should not be zero extended but sign-extended.
> >
> > Patch by Strahinja Petrovic.
> >
> > Differential Revision: http://reviews.llvm.org/D9198
> >
> > Added:
> >     cfe/trunk/test/CodeGen/mips-unsigned-ext-var.c
> >     cfe/trunk/test/CodeGen/mips-unsigned-extend.c
> > Modified:
> >     cfe/trunk/lib/CodeGen/ABIInfo.h
> >     cfe/trunk/lib/CodeGen/CGCall.cpp
> >     cfe/trunk/lib/CodeGen/TargetInfo.cpp
> >     cfe/trunk/test/CodeGen/atomics-inlining.c
> >     cfe/trunk/test/CodeGenCXX/mips-size_t-ptrdiff_t.cpp
> >
>
> On Fedora 20/x86-64, I got
>
>
> /export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c:13:9:
> error: expected string not found in input
> // N64: call void @foo(i32 signext %0)
>         ^
> <stdin>:1:1: note: scanning from here
> ; ModuleID =
> '/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c'
> ^
> <stdin>:17:2: note: possible intended match here
>  call void @foo(i32 signext %1)
>


Same here.

And additionally the mips-unsigned-ext-var.c test fails:

 clang/test/CodeGen/mips-unsigned-ext-var.c:5:10: fatal error: 'stdarg.h'
file not found
 #include <stdarg.h>

          ^

 1 error generated.

 FileCheck error: '-' is empty.



Could you please fix the issue or revert the commit?

Thanks!

-- Alex


>
>
> --
> H.J.
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150526/dcd7a041/attachment.html>


More information about the cfe-commits mailing list