<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 26, 2015 at 5:20 PM, H.J. Lu <span dir="ltr"><<a href="mailto:hjl.tools@gmail.com" target="_blank">hjl.tools@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Tue, May 26, 2015 at 6:30 AM, Petar Jovanovic<br>
<<a href="mailto:petar.jovanovic@imgtec.com">petar.jovanovic@imgtec.com</a>> wrote:<br>
> Author: petarj<br>
> Date: Tue May 26 08:30:54 2015<br>
> New Revision: 238200<br>
><br>
> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238200-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=fYYE8dFrYYRHcYflIvjRAGzI8uEZVgQEutQMGnoJytk&s=Sasq6Brq1tGP1qWnnoujzm-dofZxSmJ3urECB5eBbpk&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238200&view=rev</a><br>
> Log:<br>
> [MIPS] fix extension of integer types (function calls)<br>
><br>
> On MIPS unsigned int type should not be zero extended but sign-extended.<br>
><br>
> Patch by Strahinja Petrovic.<br>
><br>
> Differential Revision: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9198&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=fYYE8dFrYYRHcYflIvjRAGzI8uEZVgQEutQMGnoJytk&s=AGV4h0XNMgWJhUYFfqTYU2F7f6Bg-nEb4xn8EEd8c4A&e=" target="_blank">http://reviews.llvm.org/D9198</a><br>
><br>
> Added:<br>
>     cfe/trunk/test/CodeGen/mips-unsigned-ext-var.c<br>
>     cfe/trunk/test/CodeGen/mips-unsigned-extend.c<br>
> Modified:<br>
>     cfe/trunk/lib/CodeGen/ABIInfo.h<br>
>     cfe/trunk/lib/CodeGen/CGCall.cpp<br>
>     cfe/trunk/lib/CodeGen/TargetInfo.cpp<br>
>     cfe/trunk/test/CodeGen/atomics-inlining.c<br>
>     cfe/trunk/test/CodeGenCXX/mips-size_t-ptrdiff_t.cpp<br>
><br>
<br>
</span>On Fedora 20/x86-64, I got<br>
<br>
/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c:13:9:<br>
error: expected string not found in input<br>
<span class="">// N64: call void @foo(i32 signext %0)<br>
</span>        ^<br>
<stdin>:1:1: note: scanning from here<br>
; ModuleID = '/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c'<br>
^<br>
<stdin>:17:2: note: possible intended match here<br>
 call void @foo(i32 signext %1)<br></blockquote><div><br></div><div><br></div><div>Same here. </div><div><br></div><div>And additionally the mips-unsigned-ext-var.c test fails:</div><div><br></div></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div class="gmail_extra"><div class="gmail_quote"><div><div> clang/test/CodeGen/mips-unsigned-ext-var.c:5:10: fatal error: 'stdarg.h' file not found</div></div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div> #include <stdarg.h>                                                              </div></div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div>          ^                                                                       </div></div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div> 1 error generated.                                                               </div></div></div></div><div class="gmail_extra"><div class="gmail_quote"><div><div> FileCheck error: '-' is empty.                                                   </div></div></div></div></blockquote><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Could you please fix the issue or revert the commit?<br><br></div><div>Thanks!</div><div><br></div><div>-- Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888"><br>
<br>
--<br>
H.J.<br>
</font></span><div class=""><div class="h5">_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><div><br></div>
</div></div>