[PATCH] Fix for #pragma warning to work correctly with "1-4:" specifiers

Reid Kleckner rnk at google.com
Thu May 21 08:35:25 PDT 2015


Yes, check lines for pragma warning 1.

Sent from phone
On May 21, 2015 5:57 AM, "Andrey Bokhanko" <andreybokhanko at gmail.com> wrote:

> ================
> Comment at: test/Preprocessor/pragma_microsoft_E.c:83
> @@ +82,3 @@
> +// Test that we parsed all pragmas successfully and not produced any
> warnings
> +// CHECK-NOT: warning:
> +
> ----------------
> rnk wrote:
> > You should check that the warning pragmas roundtrip through the
> preprocessor, though.
> Reid, sorry for a noob question -- what do you mean by checking "roundtrip
> through the preprocessor"? Is there an existing test I can use as an
> example?
>
> In the updated patch I added CHECKs for preprocessor's output -- is this
> what you meant?
>
> http://reviews.llvm.org/D9856
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150521/c114dfc5/attachment.html>


More information about the cfe-commits mailing list