<p dir="ltr">Yes, check lines for pragma warning 1.</p>
<p dir="ltr">Sent from phone</p>
<div class="gmail_quote">On May 21, 2015 5:57 AM, "Andrey Bokhanko" <<a href="mailto:andreybokhanko@gmail.com">andreybokhanko@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: test/Preprocessor/pragma_microsoft_E.c:83<br>
@@ +82,3 @@<br>
+// Test that we parsed all pragmas successfully and not produced any warnings<br>
+// CHECK-NOT: warning:<br>
+<br>
----------------<br>
rnk wrote:<br>
> You should check that the warning pragmas roundtrip through the preprocessor, though.<br>
Reid, sorry for a noob question -- what do you mean by checking "roundtrip through the preprocessor"? Is there an existing test I can use as an example?<br>
<br>
In the updated patch I added CHECKs for preprocessor's output -- is this what you meant?<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9856&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=MIHM6DK4JqDwNBNNPUHMDxXViiPYzuSV2jYm1B0BIQM&s=3Qi9GA2_oNjAI13DnVIG4p93yGp1e7lHqw2D4s86VIA&e=" target="_blank">http://reviews.llvm.org/D9856</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=MIHM6DK4JqDwNBNNPUHMDxXViiPYzuSV2jYm1B0BIQM&s=0ej3cNy7V1JLvDFmv2Az8zw1Oah8yz8tiB4kgHpfySU&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div>