[PATCH] NaCl ARM: fix assembler float abi flags

[Derek Schuff]

================
Comment at: lib/Driver/Tools.cpp:7401
@@ -7400,3 +7400,3 @@
   case llvm::Triple::thumbeb: {
     const llvm::Triple &Triple = getToolChain().getTriple();
     switch (Triple.getSubArch()) {
----------------
jvoung wrote:
> Should this just set Triple = llvm::Triple(getToolChain().ComputeEffectiveClangTriple(Args)); here?
> 
> In case other stuff in this case statement depends on the triple later.
That causes -mfpu=neon to be added to the linux build as well as NaCl (that causes the linux-as.c test to fail, which uses cortex-a8 as the cpu but does not expect -mfpu=neon). IIUC it should be ok to have -mfpu=neon (for both linux and nacl) because we always default to .fpu neon  in the asm file when targeting cortex-a8. But that seems to mean that the assembler doesn't even care (at least for linux and nacl) whether it gets -mfpu=neon or not. I don't really understand why it should care anyway.

http://reviews.llvm.org/D8902

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/