[PATCH] NaCl ARM: fix assembler float abi flags

Jan Voung jvoung at chromium.org
Fri Apr 10 09:34:57 PDT 2015


Otherwise LGTM


================
Comment at: lib/Driver/Tools.cpp:7401
@@ -7400,3 +7400,3 @@
   case llvm::Triple::thumbeb: {
     const llvm::Triple &Triple = getToolChain().getTriple();
     switch (Triple.getSubArch()) {
----------------
Should this just set Triple = llvm::Triple(getToolChain().ComputeEffectiveClangTriple(Args)); here?

In case other stuff in this case statement depends on the triple later.

http://reviews.llvm.org/D8902

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list