[PATCH] [OPENMP] Improved codegen for implicit/explicit 'barrier' constructs.
Alexey Bataev
a.bataev at hotmail.com
Sun Mar 29 21:01:08 PDT 2015
John, tanks for the review!
================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:375
@@ -366,1 +374,3 @@
+ virtual void emitImplicitBarrierCall(CodeGenFunction &CGF, SourceLocation Loc,
+ OpenMPDirectiveKind Kind = OMPD_unknown);
----------------
rjmccall wrote:
> I think you should be able to just pass OMPD_barrier for explicit barriers.
>
> Don't have this take a default argument; make the caller think about it and opt in to OMPD_unknown if they want that.
Ok, I'll do this.
http://reviews.llvm.org/D8659
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list