[PATCH] [OPENMP] Improved codegen for implicit/explicit 'barrier' constructs.

John McCall rjmccall at gmail.com
Fri Mar 27 10:41:37 PDT 2015


================
Comment at: lib/CodeGen/CGOpenMPRuntime.h:375
@@ -366,1 +374,3 @@
+  virtual void emitImplicitBarrierCall(CodeGenFunction &CGF, SourceLocation Loc,
+                                       OpenMPDirectiveKind Kind = OMPD_unknown);
 
----------------
I think you should be able to just pass OMPD_barrier for explicit barriers.

Don't have this take a default argument; make the caller think about it and opt in to OMPD_unknown if they want that.

http://reviews.llvm.org/D8659

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list