[PATCH] Add Clang support for remaining integer divide and permute instructions from ISA 2.06

Nemanja Ivanovic nemanja.i.ibm at gmail.com
Thu Mar 26 07:20:46 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/CGBuiltin.cpp:6411
@@ +6410,3 @@
+                        BuiltinID == PPC::BI__builtin_bpermd;
+    if(!getTarget().hasFeature("bpermd") && !getTarget().hasFeature("extdiv")) {
+      CGM.Error(E->getExprLoc(),
----------------
wschmidt wrote:
> You need to split these conditions so that the bpermd feature only controls BI_ _builtin_bpermd and the extdiv feature only controls BI_ _builtin_div*.
Good point! We don't want to suppress the diagnostics for the other when only one is enabled :-). Not sure what I was thinking here. I'll fix it in the committed patch. Or would you like another review for just this (of course, if there are other comments this question is moot)?

http://reviews.llvm.org/D8398

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list