[PATCH] Add Clang support for remaining integer divide and permute instructions from ISA 2.06

Bill Schmidt wschmidt at linux.vnet.ibm.com
Thu Mar 26 06:23:18 PDT 2015


LGTM with one small change.


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/CGBuiltin.cpp:6411
@@ +6410,3 @@
+                        BuiltinID == PPC::BI__builtin_bpermd;
+    if(!getTarget().hasFeature("bpermd") && !getTarget().hasFeature("extdiv")) {
+      CGM.Error(E->getExprLoc(),
----------------
You need to split these conditions so that the bpermd feature only controls BI_ _builtin_bpermd and the extdiv feature only controls BI_ _builtin_div*.

http://reviews.llvm.org/D8398

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list