[PATCH] Command-line options to set debugger "target"

[Eric Christopher]

You could handle some of the DW_AT_APPLE foo things that way?

-eric

On Wed, Mar 25, 2015 at 2:47 PM Paul Robinson <
Paul_Robinson at playstation.sony.com> wrote:

> ================
> Comment at: include/clang/Driver/Options.td:1051
> @@ -1047,1 +1050,3 @@
> +def gsce : Flag<["-"], "gsce">, Group<g_flags_Group>,
> +  HelpText<"Tune debug info for an SCE target (e.g. PS4)">,
> Flags<[CC1Option]>;
>  def gdwarf_2 : Flag<["-"], "gdwarf-2">, Group<g_Group>,
> ----------------
> dblaikie wrote:
> > Is SCE usually pronounced with each letter separately, or as a word
> ("ski" or similar)? (wondering whether "an SCE target" or "a SCE target" is
> correct)
> SCE = ess see ee (Sony Computer Entertainment)
> There is a European division, SCEE, which I have heard pronounced as "ski."
>
>
> ================
> Comment at: include/clang/Frontend/CodeGenOptions.def:159
> @@ +158,3 @@
> +/// Which debugger we are targeting.
> +ENUM_CODEGENOPT(Debugger, llvm::DebuggerKind, 2, llvm::DebuggerKind::GDB)
> +
> ----------------
> dblaikie wrote:
> > I take it that GDB is the default here? But ignored in the frontend or
> driver in favor of platform-specific defaults?
> Well, it seems to be customary to put a default here, and then initialize
> the field explicitly elsewhere anyway without relying on the default
> value.  I didn't exhaustively check every field, but eyeballing a handful
> it was certainly the pattern.
> The most entertaining case was DwarfVersion.
>
> ================
> Comment at: lib/Frontend/CompilerInvocation.cpp:408
> @@ -407,1 +407,3 @@
>
> +  if (Args.hasArg(OPT_ggdb))
> +    Opts.setDebugger(llvm::DebuggerKind::GDB);
> ----------------
> dblaikie wrote:
> > Should this handling be up in the driver? Then it should be easy to
> write tests for the defaults.
> No, it should be here, so we can specify a debugger target for -cc1 tests.
> There aren't any use-cases for that yet, but Katya's
> import-anonymous-namespace patch could use it, once it goes in.
>
> http://reviews.llvm.org/D8599
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150325/27e9e84e/attachment.html>