[PATCH] Refactor: Organize module per-check files into subdirectories for each module

[Alexander Kornienko]

On Mon, Mar 2, 2015 at 7:39 PM, Richard <legalize at xmission.com> wrote:

> My motivation is as stated: this directory is getting crowded with files
> and the more checks we add, the more crowded it is going to get.
>

test/clang-tidy still contains an order of magnitude fewer files than
almost any directory in tools/clang/test/ (CodeGen, for example). And
naming the tests appropriately makes this easily manageable.

It also makes it clear which test files are associated with a specific
> check (because they are in the subdir for the module) and which are testing
> basic functionality of clang-tidy itself (like `basic.cpp`).

Once the files are moved into a subdirectory per-module, then having the
> module name in the test file is redundant and no longer needed.  What is to
> be gained from repeating it in the filename when it is grouped into a
> subdirectory for the module?


A bit more convenience. I'm used to being able to find relevant tests using
the check name.

I agree that restructuring this directory can be a minor improvement, but
I'd better postpone this until when I have slightly more time to play with
possible options and see what's better.

Thanks for the proposal though.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150304/0bfa57f8/attachment.html>