[PATCH] [ObjC] New warning: circular containers

[AlexDenisov]

> Provide a note where receiver/argument has been declared.
Do you mean ‘add comments’?

> Place CheckObjCCircularContainer(Result) right after checkRetainCycles(Result).
It still causes weird behaviour even without ARC. Of course there is no retain cycle anymore, but app still hangs with recursion/crash.

> This patch does not address the general case of same expression used as receiver and addObject argument.
> Is this something that you care enough to address?
Do you mean something like ’[self.array addObject:self.array]’?
If so, then it doesn’t really makes sense, because we can’t ensure that returned objects are the same, there’ll be false positives.
-- 
AlexDenisov
Software Engineer, http://alexdenisov.github.io

On 3 Mar 2015 at 20:46:15, jahanian (fjahanian at apple.com) wrote:


On Mar 3, 2015, at 11:02 AM, jahanian <fjahanian at apple.com> wrote:

Patch looks good with couple of minors.
Provide a note where receiver/argument has been declared.
Place CheckObjCCircularContainer(Result) right after checkRetainCycles(Result).

This patch does not address the general case of same expression used as receiver and addObject argument.
Is this something that you care enough to address? Need not be in this patch though.


- Fariborz



_______________________________________________  
cfe-commits mailing list  
cfe-commits at cs.uiuc.edu  
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150303/0ddd7837/attachment.html>