<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">> Provide a note where receiver/argument has been declared.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">Do you mean ‘add comments’?</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">> Place CheckObjCCircularContainer(Result) right after checkRetainCycles(Result).</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">It still causes weird behaviour even without ARC. Of course there is no retain cycle anymore, but app still hangs with recursion/crash.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><br></div><div id="bloop_customfont" style="margin: 0px;"><span style="color: rgb(0, 0, 0); font-family: Helvetica, Arial; font-size: 13px;">> </span>This patch does not address the general case of same expression used as receiver and addObject argument.</div><div id="bloop_customfont" style="margin: 0px;">> Is this something that you care enough to address?</div><div id="bloop_customfont" style="margin: 0px;">Do you mean something like ’[self.array addObject:self.array]’?</div><div id="bloop_customfont" style="margin: 0px;">If so, then it doesn’t really makes sense, because we can’t ensure that returned objects are the same, there’ll be false positives.</div> <div id="bloop_sign_1425414448608411136" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">-- <br>AlexDenisov</div><div style="font-family:helvetica,arial;font-size:13px">Software Engineer, <a href="http://alexdenisov.github.io"><span style="color: rgb(0, 0, 0);">http://alexdenisov.github.io</span></a></div></div> <br><p style="color:#000;">On 3 Mar 2015 at 20:46:15, jahanian (<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><div>
<title></title>
<br>
<div>
<div>On Mar 3, 2015, at 11:02 AM, jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
Patch looks good with couple of minors.
<div>Provide a note where receiver/argument has been
declared.</div>
<div>Place CheckObjCCircularContainer(Result) right
after <span style="color: rgb(49, 89, 93); font-family: Menlo; font-size: 11px;">checkRetainCycles</span><span style="font-family: Menlo; font-size: 11px;">(Result).</span></div>
</div>
</blockquote>
<div><br></div>
This patch does not address the general case of same expression
used as receiver and addObject argument.
<div>Is this something that you care enough to address? Need not be
in this patch though.</div>
<div><br></div>
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div><span style="font-family: Menlo; font-size: 11px;"><br></span></div>
<div><span style="font-family: Menlo; font-size: 11px;">-
Fariborz</span></div>
<div><span style="font-family: Menlo; font-size: 11px;"><br></span></div>
<div><br></div>
</div>
</blockquote>
</div>
<br>
_______________________________________________
<br>cfe-commits mailing list
<br>cfe-commits@cs.uiuc.edu
<br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
<br></div></div></span></blockquote></body></html>