[PATCH] CodeGen: Emit constant array temporaries into read-only globals.

[Rafael Espíndola]

>> What is the issue with private on COFF? For ELF at least private is
>> the correct choice for this.
>
>
> We explicitly forbid making private linkage entities COMDAT here:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?revision=230707&view=markup#l859

In this case the ComdatGV would be the function, which is not private, no?

Medium term, we should probably change CodeGen to handle private for
COFF in all cases. Is the issue that COFF requires a "normal" symbol
to be the symbol identifying the comdat? If so, CodeGen should just
output of the symbol even if it is private when it is the "id" of a
comdat.

This is similar to the change that was done for MachO in
http://llvm.org/bugs/show_bug.cgi?id=18743.

Cheers,
Rafael