[PATCH] CodeGen: Emit constant array temporaries into read-only globals.

[David Majnemer]

On Tue, Mar 3, 2015 at 10:21 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 3 March 2015 at 07:51, David Majnemer <david.majnemer at gmail.com> wrote:
> > It would be nice to give it internal linkage instead of private.  That
> way the linker could zap these globals for targets which use COFF when they
> are unreferenced.
>
> What is the issue with private on COFF? For ELF at least private is
> the correct choice for this.
>

We explicitly forbid making private linkage entities COMDAT here:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetLoweringObjectFileImpl.cpp?revision=230707&view=markup#l859

Last time I tried, I couldn't get this to work.


>
> Cheers,
> Rafael
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150303/ebdf0a53/attachment.html>