[PATCH] Add support for a few Objective-C matchers.

[Dean Sutherland]

Nits are now addressed. Can someone please commit this for me? I lack commit access.
Dean
 

     On Tuesday, March 3, 2015 2:49 AM, Manuel Klimek <klimek at google.com> wrote:
   

 Apart from the nits LG. Please fix those before submitting.


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2035-2039
@@ +2034,7 @@
+/// matches the [webView ...] message invocation.
+/// \code
+/// NSString *webViewJavaScript = ...
+/// UIWebView *webView = ...
+/// [webView stringByEvaluatingJavaScriptFromString:webViewJavascript];
+/// \endcode
+AST_MATCHER_P(ObjCMessageExpr, hasReceiverType, internal::Matcher<QualType>,
----------------
Please indent the code sample by 2 (make it consistent).

================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2105
@@ +2104,3 @@
+///  webView.frame = bodyFrame;
+/// //      ^---- matches here
+/// \endcode
----------------
Can you make the comment-in-the-comment align with the start of the statement above?

http://reviews.llvm.org/D7710

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150303/ec54f7b8/attachment.html>