<html><body><div style="color:#000; background-color:#fff; font-family:garamond, new york, times, serif;font-size:16px"><div id="yui_3_16_0_1_1425320575162_314694">Nits are now addressed. Can someone please commit this for me? I lack commit access.</div><div><br></div><div dir="ltr" id="yui_3_16_0_1_1425320575162_314411">Dean</div><div id="yui_3_16_0_1_1425320575162_314689" dir="ltr"><br></div><div id="yui_3_16_0_1_1425320575162_314391"><span></span></div> <div class="qtdSeparateBR"><br><br></div><div style="display: block;" class="yahoo_quoted"> <div style="font-family: garamond, new york, times, serif; font-size: 16px;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div dir="ltr"> <font face="Arial" size="2"> On Tuesday, March 3, 2015 2:49 AM, Manuel Klimek <klimek@google.com> wrote:<br> </font> </div> <br><br> <div class="y_msg_container">Apart from the nits LG. Please fix those before submitting.<br><br><br>================<br>Comment at: include/clang/ASTMatchers/ASTMatchers.h:2035-2039<br>@@ +2034,7 @@<br>+/// matches the [webView ...] message invocation.<br>+/// \code<br>+/// NSString *webViewJavaScript = ...<br>+/// UIWebView *webView = ...<br>+/// [webView stringByEvaluatingJavaScriptFromString:webViewJavascript];<br>+/// \endcode<br>+AST_MATCHER_P(ObjCMessageExpr, hasReceiverType, internal::Matcher<QualType>,<br>----------------<br>Please indent the code sample by 2 (make it consistent).<br><br>================<br>Comment at: include/clang/ASTMatchers/ASTMatchers.h:2105<br>@@ +2104,3 @@<br>+/// webView.frame = bodyFrame;<br>+/// // ^---- matches here<br>+/// \endcode<br>----------------<br>Can you make the comment-in-the-comment align with the start of the statement above?<br><br><a href="http://reviews.llvm.org/D7710" target="_blank">http://reviews.llvm.org/D7710</a><br><br>EMAIL PREFERENCES<br> <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br><br><br><br></div> </div> </div> </div> </div></body></html>