[PATCH] [libcxxabi] Fix -Werror build for 32-bit non-ARM.

[Saleem Abdulrasool]

On Sat, Feb 14, 2015 at 12:02 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> In http://reviews.llvm.org/D7419#123793, @danalbert wrote:
>
> > The user will never have to include it manually. It's the job of each
> header to make sure it is included when needed. I've turned on `-Wundef` to
> try to keep us honest about that.
>
>
> Sounds good. Waiting for Saleems reply on his requests.
>

AFAIK, this has already been committed?  IIRC Dan addressed my concerns
shortly after the commit.


> cheers,
> --renato
>
>
> ================
> Comment at: src/Unwind/Unwind-EHABI.h:16
> @@ +15,3 @@
> +
> +#if LIBCXXABI_ARM_EHABI
> +
> ----------------
> danalbert wrote:
> > rengolin wrote:
> > > danalbert wrote:
> > > > rengolin wrote:
> > > > > Is this duplication intended?
> > > > Bad merge after splitting/rebasing my change. It was fixed right
> after in a follow up patch.
> > > I can't see it. Has this change been merged already?
> >
> https://github.com/llvm-mirror/libcxxabi/commit/8906bdd7f337749838f9c310e3bb913715c4d12f
> Right. You'll squash all of them on the same commit, right?
>
> http://reviews.llvm.org/D7419
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>


-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150214/b15c1829/attachment.html>