<div dir="ltr">On Sat, Feb 14, 2015 at 12:02 PM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">In <a href="http://reviews.llvm.org/D7419#123793" target="_blank">http://reviews.llvm.org/D7419#123793</a>, @danalbert wrote:<br>
<br>
> The user will never have to include it manually. It's the job of each header to make sure it is included when needed. I've turned on `-Wundef` to try to keep us honest about that.<br>
<br>
<br>
</span>Sounds good. Waiting for Saleems reply on his requests.<br></blockquote><div><br></div><div>AFAIK, this has already been committed?  IIRC Dan addressed my concerns shortly after the commit.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
cheers,<br>
--renato<br>
<span class=""><br>
<br>
================<br>
Comment at: src/Unwind/Unwind-EHABI.h:16<br>
@@ +15,3 @@<br>
+<br>
+#if LIBCXXABI_ARM_EHABI<br>
+<br>
----------------<br>
</span><span class="">danalbert wrote:<br>
> rengolin wrote:<br>
> > danalbert wrote:<br>
> > > rengolin wrote:<br>
> > > > Is this duplication intended?<br>
> > > Bad merge after splitting/rebasing my change. It was fixed right after in a follow up patch.<br>
> > I can't see it. Has this change been merged already?<br>
> <a href="https://github.com/llvm-mirror/libcxxabi/commit/8906bdd7f337749838f9c310e3bb913715c4d12f" target="_blank">https://github.com/llvm-mirror/libcxxabi/commit/8906bdd7f337749838f9c310e3bb913715c4d12f</a><br>
</span>Right. You'll squash all of them on the same commit, right?<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D7419" target="_blank">http://reviews.llvm.org/D7419</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>