r227593 - Special-case the PS4 SDK for a clang test

[Filipe Cabecinhas]

Yes, of course. Thanks for noticing!
Fixed in r227894

  Filipe

On Mon, Feb 2, 2015 at 1:21 PM, Sean Silva <chisophugis at gmail.com> wrote:

> +# Not set on native PS4 environment.
> +if '*-scei-ps4' != config.target_triple:
> +    config.available_features.add('non-ps4-sdk')
> +
>
> Did you mean to do some sort of regex/glob match here instead of just a
> string comparison?
>
> -- Sean Silva
>
>
> On Fri, Jan 30, 2015 at 10:25 AM, Filipe Cabecinhas <me at filcab.net> wrote:
>
>> Author: filcab
>> Date: Fri Jan 30 12:25:59 2015
>> New Revision: 227593
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=227593&view=rev
>> Log:
>> Special-case the PS4 SDK for a clang test
>>
>> Original patch by Gao Yunzhong!
>>
>> Modified:
>>     cfe/trunk/test/Driver/nostdincxx.cpp
>>     cfe/trunk/test/lit.cfg
>>
>> Modified: cfe/trunk/test/Driver/nostdincxx.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/nostdincxx.cpp?rev=227593&r1=227592&r2=227593&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/Driver/nostdincxx.cpp (original)
>> +++ cfe/trunk/test/Driver/nostdincxx.cpp Fri Jan 30 12:25:59 2015
>> @@ -4,3 +4,4 @@
>>
>>  // MSVC has C++ headers in same directory as C headers.
>>  // REQUIRES: non-ms-sdk
>> +// REQUIRES: non-ps4-sdk
>>
>> Modified: cfe/trunk/test/lit.cfg
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=227593&r1=227592&r2=227593&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/lit.cfg (original)
>> +++ cfe/trunk/test/lit.cfg Fri Jan 30 12:25:59 2015
>> @@ -404,6 +404,10 @@ if not re.match(r'.*-win32$', config.tar
>>  if not re.match(r'.*-win32$', config.target_triple):
>>      config.available_features.add('non-ms-sdk')
>>
>> +# Not set on native PS4 environment.
>> +if '*-scei-ps4' != config.target_triple:
>> +    config.available_features.add('non-ps4-sdk')
>> +
>>  # [PR8833] LLP64-incompatible tests
>>  if not re.match(r'^x86_64.*-(win32|mingw32|windows-gnu)$',
>> config.target_triple):
>>      config.available_features.add('LP64')
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150202/63d71a23/attachment.html>