<div dir="ltr">Yes, of course. Thanks for noticing!<div>Fixed in r227894<br></div><div><br></div><div>  Filipe</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 2, 2015 at 1:21 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class=""><span style="font-size:13px">+# Not set on native PS4 environment.</span><br style="font-size:13px"><span style="font-size:13px">+if '*-scei-ps4' != config.target_triple:</span><br style="font-size:13px"><span style="font-size:13px">+    config.available_features.add(</span><span style="font-size:13px">'non-ps4-sdk')</span><br style="font-size:13px"><span style="font-size:13px">+</span><br><div><span style="font-size:13px"><br></span></div></span><div><span style="font-size:13px">Did you mean to do some sort of regex/glob match here instead of just a string comparison?</span></div><span class="HOEnZb"><font color="#888888"><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">-- Sean Silva</span></div><div><span style="font-size:13px"><br></span></div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 30, 2015 at 10:25 AM, Filipe Cabecinhas <span dir="ltr"><<a href="mailto:me@filcab.net" target="_blank">me@filcab.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: filcab<br>
Date: Fri Jan 30 12:25:59 2015<br>
New Revision: 227593<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=227593&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=227593&view=rev</a><br>
Log:<br>
Special-case the PS4 SDK for a clang test<br>
<br>
Original patch by Gao Yunzhong!<br>
<br>
Modified:<br>
    cfe/trunk/test/Driver/nostdincxx.cpp<br>
    cfe/trunk/test/lit.cfg<br>
<br>
Modified: cfe/trunk/test/Driver/nostdincxx.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/nostdincxx.cpp?rev=227593&r1=227592&r2=227593&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/nostdincxx.cpp?rev=227593&r1=227592&r2=227593&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/nostdincxx.cpp (original)<br>
+++ cfe/trunk/test/Driver/nostdincxx.cpp Fri Jan 30 12:25:59 2015<br>
@@ -4,3 +4,4 @@<br>
<br>
 // MSVC has C++ headers in same directory as C headers.<br>
 // REQUIRES: non-ms-sdk<br>
+// REQUIRES: non-ps4-sdk<br>
<br>
Modified: cfe/trunk/test/lit.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=227593&r1=227592&r2=227593&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=227593&r1=227592&r2=227593&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/lit.cfg (original)<br>
+++ cfe/trunk/test/lit.cfg Fri Jan 30 12:25:59 2015<br>
@@ -404,6 +404,10 @@ if not re.match(r'.*-win32$', config.tar<br>
 if not re.match(r'.*-win32$', config.target_triple):<br>
     config.available_features.add('non-ms-sdk')<br>
<br>
+# Not set on native PS4 environment.<br>
+if '*-scei-ps4' != config.target_triple:<br>
+    config.available_features.add('non-ps4-sdk')<br>
+<br>
 # [PR8833] LLP64-incompatible tests<br>
 if not re.match(r'^x86_64.*-(win32|mingw32|windows-gnu)$', config.target_triple):<br>
     config.available_features.add('LP64')<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>