[PATCH] fix for bug 22236

[Sean Silva]

On Thu, Jan 15, 2015 at 12:48 AM, Nicolas Brunie <nicolas.brunie at kalray.eu>
wrote:

> Hi All,
>        I just submitted bug 22236 for clang (http://llvm.org/bugs/show_
> bug.cgi?id=22236) and was asked to submit my suggested commit to this
> list.
>     So here it is. This is a very low priority, "error message bug", but
> since I would like to contribute to the project in the future, It seems a
> good introduction to start with that submission.


Indeed, this is a great place to start. Committed in r226328. Could you
close PR22236?


> Sorry if I did not follow the protocol adequately.
>

We generally tend to prefer having patches as attachments (which seems to
be the only universal way to ensure all email clients to not mangle the
patch), but this patch was so small I was able to apply it manually no
problem.

-- Sean Silva


>
> Best regards,
> Nicolas Brunie
>
> P.S: while preparing a commit for clang trunk rather than the LLVM 3.5.1
> version I am using, I found that an other message was wrong and included it
> in the patch
>
> From f3ca32d45c67464221175f4367b97d055aa377f8 Mon Sep 17 00:00:00 2001
> From: Nicolas Brunie <nicolas.brunie at kalray.eu>
> Date: Thu, 15 Jan 2015 09:41:55 +0100
> Subject: [PATCH] [#22236] fixing error messages in DecodeTypeFromStr
>
> ---
>  lib/AST/ASTContext.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp
> index 6b864d0..68e594b 100644
> --- a/lib/AST/ASTContext.cpp
> +++ b/lib/AST/ASTContext.cpp
> @@ -7543,7 +7543,7 @@ static QualType DecodeTypeFromStr(const char *&Str,
> const ASTContext &Context,
>        break;
>      case 'U':
>        assert(!Signed && "Can't use both 'S' and 'U' modifiers!");
> -      assert(!Unsigned && "Can't use 'S' modifier multiple times!");
> +      assert(!Unsigned && "Can't use 'U' modifier multiple times!");
>        Unsigned = true;
>        break;
>      case 'L':
> @@ -7578,7 +7578,7 @@ static QualType DecodeTypeFromStr(const char *&Str,
> const ASTContext &Context,
>      break;
>    case 'h':
>      assert(HowLong == 0 && !Signed && !Unsigned &&
> -           "Bad modifiers used with 'f'!");
> +           "Bad modifiers used with 'h'!");
>      Type = Context.HalfTy;
>      break;
>    case 'f':
> --
> 1.8.3.1
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150116/2f2ff6b9/attachment.html>