[PATCH] fix for bug 22236

Nicolas Brunie nicolas.brunie at kalray.eu
Thu Jan 15 00:48:32 PST 2015


Hi All,
        I just submitted bug 22236 for clang 
(http://llvm.org/bugs/show_bug.cgi?id=22236) and was asked to submit my 
suggested commit to this list.
     So here it is. This is a very low priority, "error message bug", 
but since I would like to contribute to the project in the future, It 
seems a good introduction to start with that submission. Sorry if I did 
not follow the protocol adequately.

Best regards,
Nicolas Brunie

P.S: while preparing a commit for clang trunk rather than the LLVM 3.5.1 
version I am using, I found that an other message was wrong and included 
it in the patch

 From f3ca32d45c67464221175f4367b97d055aa377f8 Mon Sep 17 00:00:00 2001
From: Nicolas Brunie <nicolas.brunie at kalray.eu>
Date: Thu, 15 Jan 2015 09:41:55 +0100
Subject: [PATCH] [#22236] fixing error messages in DecodeTypeFromStr

---
  lib/AST/ASTContext.cpp | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp
index 6b864d0..68e594b 100644
--- a/lib/AST/ASTContext.cpp
+++ b/lib/AST/ASTContext.cpp
@@ -7543,7 +7543,7 @@ static QualType DecodeTypeFromStr(const char 
*&Str, const ASTContext &Context,
        break;
      case 'U':
        assert(!Signed && "Can't use both 'S' and 'U' modifiers!");
-      assert(!Unsigned && "Can't use 'S' modifier multiple times!");
+      assert(!Unsigned && "Can't use 'U' modifier multiple times!");
        Unsigned = true;
        break;
      case 'L':
@@ -7578,7 +7578,7 @@ static QualType DecodeTypeFromStr(const char 
*&Str, const ASTContext &Context,
      break;
    case 'h':
      assert(HowLong == 0 && !Signed && !Unsigned &&
-           "Bad modifiers used with 'f'!");
+           "Bad modifiers used with 'h'!");
      Type = Context.HalfTy;
      break;
    case 'f':
-- 
1.8.3.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bugfix_22236.patch
Type: text/x-patch
Size: 1188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150115/8628a46b/attachment.bin>


More information about the cfe-commits mailing list