[patch] Remove ASTConsumer::HandleVTable()'s bool parameter

[Nico Weber]

Looks like Sylvestre fixed this in r226162.

On Wed, Jan 14, 2015 at 10:24 PM, Francisco Lopes <
francisco.mailing.lists at oblita.com> wrote:

> This breaks LLDB build.
>
> 2015-01-15 2:09 GMT-02:00 Nico Weber <thakis at chromium.org>:
>
> r226096, thanks!
>>
>> On Wed, Jan 14, 2015 at 4:41 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>>> lgtm
>>>
>>> On Mon, Jan 12, 2015 at 8:17 PM, Nico Weber <thakis at chromium.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> sema calls HandleVTable() with a bool parameter which is then threaded
>>>> through three layers. The only effect of this bool is an early return at
>>>> the last layer.
>>>>
>>>> Instead, remove this parameter and call HandleVTable() only if the bool
>>>> is true. No intended behavior change, this is just a code simplification.
>>>>
>>>> I'm not sure why these three hops are done – it's not due to code rot,
>>>> this was added in one piece in r103718. That's why I'm not just landing
>>>> this but asking for precommit review – does anyone know if there's a reason
>>>> for the current path?
>>>>
>>>> Nico
>>>>
>>>> _______________________________________________
>>>> cfe-commits mailing list
>>>> cfe-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>
>>>>
>>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150115/97449875/attachment.html>