r224718 - Rename test.cc files to test.cpp.

Nico Weber thakis at chromium.org
Mon Dec 22 17:09:25 PST 2014


As you can tell from the commit message, I know as much as you about this
test. I just added a triple to it (in r224747), which I think is how this
issue is usually fixed. (If I use an armv7-unknown-unknown triple, I can
reproduce the failure, so chances are that that'll help.)

On Mon, Dec 22, 2014 at 4:52 PM, Renato Golin <renato.golin at linaro.org>
wrote:

> Hi Nico,
>
> It seems you're expecting the function to always need three arguments, but
> on ARM it has only to?
>
> Not sure what the issue is here...
>
>
> http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2054
>
> Cheers,
> Renato
> On 22 Dec 2014 19:14, "Nico Weber" <nicolasweber at gmx.de> wrote:
>
>> Author: nico
>> Date: Mon Dec 22 12:13:07 2014
>> New Revision: 224718
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=224718&view=rev
>> Log:
>> Rename test.cc files to test.cpp.
>>
>> The lit.cfg files only add .cpp to suffixes, so these tests used to never
>> run,
>> oops.  (Also tweak to of these tests in minor ways to make the actually
>> pass.)
>>
>> Added:
>>     cfe/trunk/test/CodeGen/builtin-recursive.cpp
>>       - copied, changed from r224710,
>> cfe/trunk/test/CodeGen/builtin-recursive.cc
>>     cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cpp
>>       - copied unchanged from r224710,
>> cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc
>>     cfe/trunk/test/CodeGenCXX/pr21989.cpp
>>       - copied unchanged from r224710,
>> cfe/trunk/test/CodeGenCXX/pr21989.cc
>>     cfe/trunk/test/Driver/freebsd.cpp
>>       - copied unchanged from r224710, cfe/trunk/test/Driver/freebsd.cc
>>     cfe/trunk/test/Sema/128bitfloat.cpp
>>       - copied unchanged from r224710, cfe/trunk/test/Sema/128bitfloat.cc
>>     cfe/trunk/test/SemaCXX/vtable-instantiation.cpp
>>       - copied, changed from r224710,
>> cfe/trunk/test/SemaCXX/vtable-instantiation.cc
>> Removed:
>>     cfe/trunk/test/CodeGen/builtin-recursive.cc
>>     cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc
>>     cfe/trunk/test/CodeGenCXX/pr21989.cc
>>     cfe/trunk/test/Driver/freebsd.cc
>>     cfe/trunk/test/Sema/128bitfloat.cc
>>     cfe/trunk/test/SemaCXX/vtable-instantiation.cc
>>
>> Removed: cfe/trunk/test/CodeGen/builtin-recursive.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/CodeGen/builtin-recursive.cc (original)
>> +++ cfe/trunk/test/CodeGen/builtin-recursive.cc (removed)
>> @@ -1,10 +0,0 @@
>> -// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem Inputs
>> -emit-llvm-only %s
>> -
>> -// This used to cause a read past the end of a global variable.
>> -
>> -#include <stdio.h>
>> -
>> -void testcase(void) {
>> -  vprintf(0, 0);
>> -}
>> -
>>
>> Copied: cfe/trunk/test/CodeGen/builtin-recursive.cpp (from r224710,
>> cfe/trunk/test/CodeGen/builtin-recursive.cc)
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cpp?p2=cfe/trunk/test/CodeGen/builtin-recursive.cpp&p1=cfe/trunk/test/CodeGen/builtin-recursive.cc&r1=224710&r2=224718&rev=224718&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/CodeGen/builtin-recursive.cc (original)
>> +++ cfe/trunk/test/CodeGen/builtin-recursive.cpp Mon Dec 22 12:13:07 2014
>> @@ -1,4 +1,4 @@
>> -// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem Inputs
>> -emit-llvm-only %s
>> +// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem %S/Inputs
>> -emit-llvm-only %s
>>
>>  // This used to cause a read past the end of a global variable.
>>
>>
>> Removed: cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc (original)
>> +++ cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc (removed)
>> @@ -1,17 +0,0 @@
>> -// RUN: %clang_cc1 -emit-llvm-only %s
>> -// PR9178
>> -
>> -void abort() __attribute__((__noreturn__));
>> -struct CoinModelLink {
>> -  CoinModelLink();
>> -  ~CoinModelLink();
>> -};
>> -class CoinModel {
>> -  CoinModelLink firstInQuadraticColumn();
>> -};
>> -CoinModelLink CoinModel::firstInQuadraticColumn() {
>> -  abort();
>> -  CoinModelLink x;
>> -  return x;
>> -}
>> -
>>
>> Removed: cfe/trunk/test/CodeGenCXX/pr21989.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pr21989.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/CodeGenCXX/pr21989.cc (original)
>> +++ cfe/trunk/test/CodeGenCXX/pr21989.cc (removed)
>> @@ -1,9 +0,0 @@
>> -// REQUIRES: asserts
>> -// RUN: not %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - %s
>> 2>&1 | FileCheck %s
>> -
>> -struct {
>> -  void __attribute__((used)) f() {}
>> -};
>> -// CHECK: 2 errors generated.
>> -
>> -// Emit the errors, but don't assert.
>>
>> Removed: cfe/trunk/test/Driver/freebsd.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/freebsd.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/Driver/freebsd.cc (original)
>> +++ cfe/trunk/test/Driver/freebsd.cc (removed)
>> @@ -1,6 +0,0 @@
>> -// RUN: %clangxx %s -### -o %t.o -target amd64-unknown-freebsd10.0 2>&1 \
>> -// RUN:   | FileCheck --check-prefix=CHECK-TEN %s
>> -// RUN: %clangxx %s -### -o %t.o -target amd64-unknown-freebsd9.2 2>&1 \
>> -// RUN:   | FileCheck --check-prefix=CHECK-NINE %s
>> -// CHECK-TEN: -lc++
>> -// CHECK-NINE: -lstdc++
>>
>> Removed: cfe/trunk/test/Sema/128bitfloat.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/128bitfloat.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/Sema/128bitfloat.cc (original)
>> +++ cfe/trunk/test/Sema/128bitfloat.cc (removed)
>> @@ -1,24 +0,0 @@
>> -// RUN: %clang_cc1 -fsyntax-only -verify -std=gnu++11 %s
>> -// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
>> -
>> -#if !defined(__STRICT_ANSI__)
>> -__float128 f;  // expected-error {{support for type '__float128' is not
>> yet implemented}}
>> -// But this should work:
>> -template<typename> struct __is_floating_point_helper {};
>> -template<> struct __is_floating_point_helper<__float128> {};
>> -
>> -// FIXME: This could have a better diag.
>> -void g(int x, __float128 *y) {
>> -  x + *y;  // expected-error {{invalid operands to binary expression
>> ('int' and '__float128')}}
>> -}
>> -
>> -#else
>> -__float128 f;  // expected-error {{unknown type name '__float128'}}
>> -template<typename> struct __is_floating_point_helper {};
>> -template<> struct __is_floating_point_helper<__float128> {};  //
>> expected-error {{use of undeclared identifier '__float128'}}
>> -
>> -void g(int x, __float128 *y) {  // expected-error {{unknown type name
>> '__float128'}}
>> -  x + *y;
>> -}
>> -
>> -#endif
>>
>> Removed: cfe/trunk/test/SemaCXX/vtable-instantiation.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cc?rev=224717&view=auto
>>
>> ==============================================================================
>> --- cfe/trunk/test/SemaCXX/vtable-instantiation.cc (original)
>> +++ cfe/trunk/test/SemaCXX/vtable-instantiation.cc (removed)
>> @@ -1,68 +0,0 @@
>> -// RUN: %clang_cc1 -fsyntax-only -verify %s
>> -
>> -namespace PR8640 {
>> -  template<class T1> struct C1 {
>> -    virtual void c1() {
>> -      T1 t1 = 3;  // expected-error {{cannot initialize a variable}}
>> -    }
>> -  };
>> -
>> -  template<class T2> struct C2 {
>> -    void c2() {
>> -      new C1<T2>();  // expected-note {{in instantiation of member
>> function}}
>> -    }
>> -  };
>> -
>> -  void f() {
>> -    C2<int*> c2;
>> -    c2.c2();  // expected-note {{in instantiation of member function}}
>> -  }
>> -}
>> -
>> -namespace PR9325 {
>> -  template<typename T>
>> -  class Target
>> -  {
>> -  public:
>> -    virtual T Value() const
>> -    {
>> -      return 1; // expected-error{{cannot initialize return object of
>> type 'int *' with an rvalue of type 'int'}}
>> -    }
>> -  };
>> -
>> -  template<typename T>
>> -  struct Provider
>> -  {
>> -    static Target<T> Instance;
>> -  };
>> -
>> -  template<typename T>
>> -  Target<T> Provider<T>::Instance; // expected-note{{in instantiation
>> of}}
>> -
>> -  void f()
>> -  {
>> -    Target<int*>* traits = &Provider<int*>::Instance;
>> -  }
>> -}
>> -
>> -namespace PR10020 {
>> -  struct MG {
>> -    virtual void Accept(int) = 0;
>> -  };
>> -
>> -  template <typename Type>
>> -  struct GMG : MG {
>> -    void Accept(int i) {
>> -      static_cast<Type *>(0)->Accept(i); // expected-error{{member
>> reference base}}
>> -    }
>> -    static GMG* Method() { return &singleton; } // expected-note{{in
>> instantiation of}}
>> -    static GMG singleton;
>> -  };
>> -
>> -  template <typename Type>
>> -  GMG<Type> GMG<Type>::singleton;
>> -
>> -  void test(void) {
>> -    GMG<int>::Method(); // expected-note{{in instantiation of}}
>> -  }
>> -}
>>
>> Copied: cfe/trunk/test/SemaCXX/vtable-instantiation.cpp (from r224710,
>> cfe/trunk/test/SemaCXX/vtable-instantiation.cc)
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cpp?p2=cfe/trunk/test/SemaCXX/vtable-instantiation.cpp&p1=cfe/trunk/test/SemaCXX/vtable-instantiation.cc&r1=224710&r2=224718&rev=224718&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/SemaCXX/vtable-instantiation.cc (original)
>> +++ cfe/trunk/test/SemaCXX/vtable-instantiation.cpp Mon Dec 22 12:13:07
>> 2014
>> @@ -41,7 +41,7 @@ namespace PR9325 {
>>
>>    void f()
>>    {
>> -    Target<int*>* traits = &Provider<int*>::Instance;
>> +    Target<int*>* traits = &Provider<int*>::Instance; //
>> expected-note{{requested here}}
>>    }
>>  }
>>
>> @@ -60,7 +60,7 @@ namespace PR10020 {
>>    };
>>
>>    template <typename Type>
>> -  GMG<Type> GMG<Type>::singleton;
>> +  GMG<Type> GMG<Type>::singleton; // expected-note{{requested here}}
>>
>>    void test(void) {
>>      GMG<int>::Method(); // expected-note{{in instantiation of}}
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141222/05f01527/attachment.html>


More information about the cfe-commits mailing list