<div dir="ltr">As you can tell from the commit message, I know as much as you about this test. I just added a triple to it (in r224747), which I think is how this issue is usually fixed. (If I use an armv7-unknown-unknown triple, I can reproduce the failure, so chances are that that'll help.)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 22, 2014 at 4:52 PM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Hi Nico, </p>
<p dir="ltr">It seems you're expecting the function to always need three arguments, but on ARM it has only to? </p>
<p dir="ltr">Not sure what the issue is here... </p>
<p dir="ltr"><a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2054" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2054</a></p>
<p dir="ltr">Cheers, <br>
Renato </p><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On 22 Dec 2014 19:14, "Nico Weber" <<a href="mailto:nicolasweber@gmx.de" target="_blank">nicolasweber@gmx.de</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nico<br>
Date: Mon Dec 22 12:13:07 2014<br>
New Revision: 224718<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=224718&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=224718&view=rev</a><br>
Log:<br>
Rename test.cc files to test.cpp.<br>
<br>
The lit.cfg files only add .cpp to suffixes, so these tests used to never run,<br>
oops. (Also tweak to of these tests in minor ways to make the actually pass.)<br>
<br>
Added:<br>
cfe/trunk/test/CodeGen/builtin-recursive.cpp<br>
- copied, changed from r224710, cfe/trunk/test/CodeGen/builtin-recursive.cc<br>
cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cpp<br>
- copied unchanged from r224710, cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc<br>
cfe/trunk/test/CodeGenCXX/pr21989.cpp<br>
- copied unchanged from r224710, cfe/trunk/test/CodeGenCXX/pr21989.cc<br>
cfe/trunk/test/Driver/freebsd.cpp<br>
- copied unchanged from r224710, cfe/trunk/test/Driver/freebsd.cc<br>
cfe/trunk/test/Sema/128bitfloat.cpp<br>
- copied unchanged from r224710, cfe/trunk/test/Sema/128bitfloat.cc<br>
cfe/trunk/test/SemaCXX/vtable-instantiation.cpp<br>
- copied, changed from r224710, cfe/trunk/test/SemaCXX/vtable-instantiation.cc<br>
Removed:<br>
cfe/trunk/test/CodeGen/builtin-recursive.cc<br>
cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc<br>
cfe/trunk/test/CodeGenCXX/pr21989.cc<br>
cfe/trunk/test/Driver/freebsd.cc<br>
cfe/trunk/test/Sema/128bitfloat.cc<br>
cfe/trunk/test/SemaCXX/vtable-instantiation.cc<br>
<br>
Removed: cfe/trunk/test/CodeGen/builtin-recursive.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/builtin-recursive.cc (original)<br>
+++ cfe/trunk/test/CodeGen/builtin-recursive.cc (removed)<br>
@@ -1,10 +0,0 @@<br>
-// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem Inputs -emit-llvm-only %s<br>
-<br>
-// This used to cause a read past the end of a global variable.<br>
-<br>
-#include <stdio.h><br>
-<br>
-void testcase(void) {<br>
- vprintf(0, 0);<br>
-}<br>
-<br>
<br>
Copied: cfe/trunk/test/CodeGen/builtin-recursive.cpp (from r224710, cfe/trunk/test/CodeGen/builtin-recursive.cc)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cpp?p2=cfe/trunk/test/CodeGen/builtin-recursive.cpp&p1=cfe/trunk/test/CodeGen/builtin-recursive.cc&r1=224710&r2=224718&rev=224718&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtin-recursive.cpp?p2=cfe/trunk/test/CodeGen/builtin-recursive.cpp&p1=cfe/trunk/test/CodeGen/builtin-recursive.cc&r1=224710&r2=224718&rev=224718&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGen/builtin-recursive.cc (original)<br>
+++ cfe/trunk/test/CodeGen/builtin-recursive.cpp Mon Dec 22 12:13:07 2014<br>
@@ -1,4 +1,4 @@<br>
-// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem Inputs -emit-llvm-only %s<br>
+// RUN: %clang_cc1 -nostdsysteminc -nobuiltininc -isystem %S/Inputs -emit-llvm-only %s<br>
<br>
// This used to cause a read past the end of a global variable.<br>
<br>
<br>
Removed: cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc (original)<br>
+++ cfe/trunk/test/CodeGenCXX/nrvo-noreturn.cc (removed)<br>
@@ -1,17 +0,0 @@<br>
-// RUN: %clang_cc1 -emit-llvm-only %s<br>
-// PR9178<br>
-<br>
-void abort() __attribute__((__noreturn__));<br>
-struct CoinModelLink {<br>
- CoinModelLink();<br>
- ~CoinModelLink();<br>
-};<br>
-class CoinModel {<br>
- CoinModelLink firstInQuadraticColumn();<br>
-};<br>
-CoinModelLink CoinModel::firstInQuadraticColumn() {<br>
- abort();<br>
- CoinModelLink x;<br>
- return x;<br>
-}<br>
-<br>
<br>
Removed: cfe/trunk/test/CodeGenCXX/pr21989.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pr21989.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pr21989.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/CodeGenCXX/pr21989.cc (original)<br>
+++ cfe/trunk/test/CodeGenCXX/pr21989.cc (removed)<br>
@@ -1,9 +0,0 @@<br>
-// REQUIRES: asserts<br>
-// RUN: not %clang_cc1 -emit-llvm -triple %itanium_abi_triple -o - %s 2>&1 | FileCheck %s<br>
-<br>
-struct {<br>
- void __attribute__((used)) f() {}<br>
-};<br>
-// CHECK: 2 errors generated.<br>
-<br>
-// Emit the errors, but don't assert.<br>
<br>
Removed: cfe/trunk/test/Driver/freebsd.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/freebsd.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/freebsd.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/freebsd.cc (original)<br>
+++ cfe/trunk/test/Driver/freebsd.cc (removed)<br>
@@ -1,6 +0,0 @@<br>
-// RUN: %clangxx %s -### -o %t.o -target amd64-unknown-freebsd10.0 2>&1 \<br>
-// RUN: | FileCheck --check-prefix=CHECK-TEN %s<br>
-// RUN: %clangxx %s -### -o %t.o -target amd64-unknown-freebsd9.2 2>&1 \<br>
-// RUN: | FileCheck --check-prefix=CHECK-NINE %s<br>
-// CHECK-TEN: -lc++<br>
-// CHECK-NINE: -lstdc++<br>
<br>
Removed: cfe/trunk/test/Sema/128bitfloat.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/128bitfloat.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/128bitfloat.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/Sema/128bitfloat.cc (original)<br>
+++ cfe/trunk/test/Sema/128bitfloat.cc (removed)<br>
@@ -1,24 +0,0 @@<br>
-// RUN: %clang_cc1 -fsyntax-only -verify -std=gnu++11 %s<br>
-// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s<br>
-<br>
-#if !defined(__STRICT_ANSI__)<br>
-__float128 f; // expected-error {{support for type '__float128' is not yet implemented}}<br>
-// But this should work:<br>
-template<typename> struct __is_floating_point_helper {};<br>
-template<> struct __is_floating_point_helper<__float128> {};<br>
-<br>
-// FIXME: This could have a better diag.<br>
-void g(int x, __float128 *y) {<br>
- x + *y; // expected-error {{invalid operands to binary expression ('int' and '__float128')}}<br>
-}<br>
-<br>
-#else<br>
-__float128 f; // expected-error {{unknown type name '__float128'}}<br>
-template<typename> struct __is_floating_point_helper {};<br>
-template<> struct __is_floating_point_helper<__float128> {}; // expected-error {{use of undeclared identifier '__float128'}}<br>
-<br>
-void g(int x, __float128 *y) { // expected-error {{unknown type name '__float128'}}<br>
- x + *y;<br>
-}<br>
-<br>
-#endif<br>
<br>
Removed: cfe/trunk/test/SemaCXX/vtable-instantiation.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cc?rev=224717&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cc?rev=224717&view=auto</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/vtable-instantiation.cc (original)<br>
+++ cfe/trunk/test/SemaCXX/vtable-instantiation.cc (removed)<br>
@@ -1,68 +0,0 @@<br>
-// RUN: %clang_cc1 -fsyntax-only -verify %s<br>
-<br>
-namespace PR8640 {<br>
- template<class T1> struct C1 {<br>
- virtual void c1() {<br>
- T1 t1 = 3; // expected-error {{cannot initialize a variable}}<br>
- }<br>
- };<br>
-<br>
- template<class T2> struct C2 {<br>
- void c2() {<br>
- new C1<T2>(); // expected-note {{in instantiation of member function}}<br>
- }<br>
- };<br>
-<br>
- void f() {<br>
- C2<int*> c2;<br>
- c2.c2(); // expected-note {{in instantiation of member function}}<br>
- }<br>
-}<br>
-<br>
-namespace PR9325 {<br>
- template<typename T><br>
- class Target<br>
- {<br>
- public:<br>
- virtual T Value() const<br>
- {<br>
- return 1; // expected-error{{cannot initialize return object of type 'int *' with an rvalue of type 'int'}}<br>
- }<br>
- };<br>
-<br>
- template<typename T><br>
- struct Provider<br>
- {<br>
- static Target<T> Instance;<br>
- };<br>
-<br>
- template<typename T><br>
- Target<T> Provider<T>::Instance; // expected-note{{in instantiation of}}<br>
-<br>
- void f()<br>
- {<br>
- Target<int*>* traits = &Provider<int*>::Instance;<br>
- }<br>
-}<br>
-<br>
-namespace PR10020 {<br>
- struct MG {<br>
- virtual void Accept(int) = 0;<br>
- };<br>
-<br>
- template <typename Type><br>
- struct GMG : MG {<br>
- void Accept(int i) {<br>
- static_cast<Type *>(0)->Accept(i); // expected-error{{member reference base}}<br>
- }<br>
- static GMG* Method() { return &singleton; } // expected-note{{in instantiation of}}<br>
- static GMG singleton;<br>
- };<br>
-<br>
- template <typename Type><br>
- GMG<Type> GMG<Type>::singleton;<br>
-<br>
- void test(void) {<br>
- GMG<int>::Method(); // expected-note{{in instantiation of}}<br>
- }<br>
-}<br>
<br>
Copied: cfe/trunk/test/SemaCXX/vtable-instantiation.cpp (from r224710, cfe/trunk/test/SemaCXX/vtable-instantiation.cc)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cpp?p2=cfe/trunk/test/SemaCXX/vtable-instantiation.cpp&p1=cfe/trunk/test/SemaCXX/vtable-instantiation.cc&r1=224710&r2=224718&rev=224718&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/vtable-instantiation.cpp?p2=cfe/trunk/test/SemaCXX/vtable-instantiation.cpp&p1=cfe/trunk/test/SemaCXX/vtable-instantiation.cc&r1=224710&r2=224718&rev=224718&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/SemaCXX/vtable-instantiation.cc (original)<br>
+++ cfe/trunk/test/SemaCXX/vtable-instantiation.cpp Mon Dec 22 12:13:07 2014<br>
@@ -41,7 +41,7 @@ namespace PR9325 {<br>
<br>
void f()<br>
{<br>
- Target<int*>* traits = &Provider<int*>::Instance;<br>
+ Target<int*>* traits = &Provider<int*>::Instance; // expected-note{{requested here}}<br>
}<br>
}<br>
<br>
@@ -60,7 +60,7 @@ namespace PR10020 {<br>
};<br>
<br>
template <typename Type><br>
- GMG<Type> GMG<Type>::singleton;<br>
+ GMG<Type> GMG<Type>::singleton; // expected-note{{requested here}}<br>
<br>
void test(void) {<br>
GMG<int>::Method(); // expected-note{{in instantiation of}}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>