[PATCH] [clang-tidy] Support initializer_list in google-explicit-constructor check

Alexander Kornienko alexfh at google.com
Thu Nov 27 03:13:27 PST 2014


================
Comment at: clang-tidy/google/ExplicitConstructorCheck.cpp:93
@@ -66,3 +92,3 @@
     DiagnosticBuilder Diag =
-        diag(Ctor->getLocation(), "%0 constructor declared explicit.")
-        << (Ctor->isMoveConstructor() ? "Move" : "Copy");
+        diag(Ctor->getLocation(), "%0 constructor declared explicit")
+        << ConstructorDescription;
----------------
djasper wrote:
> Maybe make this call for action more, e.g. "%0 constructor must not be declared explicit".
Changed the message to "X should not be declared explicit" to match the Style Guide wording.

http://reviews.llvm.org/D6427






More information about the cfe-commits mailing list