[PATCH] [clang-tidy] Support initializer_list in google-explicit-constructor check

Daniel Jasper djasper at google.com
Thu Nov 27 01:39:59 PST 2014


Looks good.

================
Comment at: clang-tidy/google/ExplicitConstructorCheck.cpp:93
@@ -66,3 +92,3 @@
     DiagnosticBuilder Diag =
-        diag(Ctor->getLocation(), "%0 constructor declared explicit.")
-        << (Ctor->isMoveConstructor() ? "Move" : "Copy");
+        diag(Ctor->getLocation(), "%0 constructor declared explicit")
+        << ConstructorDescription;
----------------
Maybe make this call for action more, e.g. "%0 constructor must not be declared explicit".

http://reviews.llvm.org/D6427






More information about the cfe-commits mailing list