[OpenCL] __generic address space for CL2.0

Sahasrabuddhe, Sameer sameer.sahasrabuddhe at amd.com
Tue Nov 25 02:28:46 PST 2014


On 11/24/2014 8:52 PM, Aaron Ballman wrote:
> Some very minor grammatical nits, but with those changes, LGTM! Sameer 
> or Pekka may have further comments, however. 

Looks good to me too! I am assuming that the file called 
"generic_keyword_v5.patch" attached to another email is the same as this 
one.

Just one itch at the back of my mind ... this documentation for 
attributes essentially breaks up the original OpenCL spec into small 
independent paragraphs. It's hard to get that right, and there are 
always gaps. I assume that this documentation is just meant to be a 
user-friendly version of the real thing. So a question to Aaron: Is 
there are an implicit understanding that some inaccuracies are okay, and 
that the interested user must always consult the original spec for the 
correct picture?

Sameer.





More information about the cfe-commits mailing list