[OpenCL] __generic address space for CL2.0

[Aaron Ballman]

On Fri, Nov 21, 2014 at 7:51 AM, Anastasia Stulova
<anastasia.stulova at arm.com> wrote:
> Hi Aaron,
>
> -----Original Message-----
> From: aaron.ballman at gmail.com [mailto:aaron.ballman at gmail.com] On Behalf Of Aaron Ballman
> Sent: 19 November 2014 13:45
> To: Anastasia Stulova
> Cc: llvm cfe
> Subject: Re: [OpenCL] __generic address space for CL2.0
>
>> Yes, thank you! I think it should be worded: "The local address space specifies that an object is allocated in the local work group memory area, which is accessible to all work items in the same work group."
>> (Same for other uses of "in the * to a work item".)
>
> "Local memory" and "work group memory" are synonyms here in a way, so I've changed it to say "local (work group) memory". The same for "private (work item) memory".
> Does it look fine now?

Some very minor grammatical nits, but with those changes, LGTM! Sameer
or Pekka may have further comments, however.

> +address space are allowed as function parameters or local variables. Starting
> +from OpenCL v2.0, global address space can be used with global (program scope)
> +variables and static local variable as well.

"Starting with OpenCL v2.0, the global address space..."

> +The local address space specifies that an object is allocated in local (work

"The local address space specifies that an object is allocated in the
local (work..."

> In a kernel function scope any variable can be in

"In a kernel function scope, any variable can be in..."

> In other scopes only pointer types to the local address

"In other scopes, only pointer types to the local address..."

> +The private address space specifies that an object is allocated in private (work

"The private address space specifies that an object is allocated in
the private (work..."

Thanks!

~Aaron