r220588 - Itanium ABI: Template template parameters are usable as substitutions

[Richard Smith]

On Mon, Oct 27, 2014 at 3:42 PM, Hans Wennborg <hans at chromium.org> wrote:

> On Fri, Oct 24, 2014 at 1:22 PM, David Majnemer
> <david.majnemer at gmail.com> wrote:
> > Author: majnemer
> > Date: Fri Oct 24 15:22:57 2014
> > New Revision: 220588
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=220588&view=rev
> > Log:
> > Itanium ABI: Template template parameters are usable as substitutions
> >
> > Template template parameters weren't added to the list of substitutions.
> > This would make the substitution map contain inaccurate mappings,
> > leading to Clang violating the Itanium ABI and breaking compatibility
> > with GCC.
> >
> > This fixes PR21351.
>
> Joerg pointed out that this might be a good candidate for merging to 3.5.1.


It's either a really good candidate or a really bad one, depending on
whether you think that it's acceptable for 3.5 and 3.5.1 to produce
ABI-incompatible code. My thinking is currently on the "really bad" side.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141027/6c1f7994/attachment.html>