[libcxx] r220512 - [libcxx] XFAIL all currently failing libc++ tests for linux.

Eric Fiselier eric at efcs.ca
Sat Oct 25 16:27:10 PDT 2014


I can't just use linux since these issues are related to GLIBC. Not all
linux(es) use GLIBC. As danalbert mentioned during review that `linux`
matches android as well.
Could you point me to your buildbot? I would like to look at the actual
triple that is produced so I can see how to match it without catching
android as well.

I will get it working on your buildbot, but I don't think just using
`linux` will work.

/Eric

On Sat, Oct 25, 2014 at 6:20 AM, İsmail Dönmez <ismail at donmez.ws> wrote:

> Hi,
>
> On Fri, Oct 24, 2014 at 12:17 AM, Eric Fiselier <eric at efcs.ca> wrote:
>
>> Author: ericwf
>> Date: Thu Oct 23 16:17:36 2014
>> New Revision: 220512
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=220512&view=rev
>> Log:
>> [libcxx] XFAIL all currently failing libc++ tests for linux.
>>
>> Summary:
>> Pretty please? We now have a significant number of builders that test
>> libc++. I really want those builders to be green.
>> Most of these failures are due to differences in locale data, including
>> those in regex. I will continue working on fixing the locale and regex
>> tests but there is no consensus on what the correct direction to go.
>>
>> Since the builders display a list of XFAIL tests they are by no means
>> hidden. It just means they are expected failures. Now unexpected failures
>> won't get mixed in with well known and expected failures.
>>
>> Reviewers: mclow.lists, jroelofs, danalbert
>>
>> Reviewed By: danalbert
>>
>> Subscribers: cfe-commits
>>
>> Differential Revision: http://reviews.llvm.org/D5941
>>
>> Modified:
>>
>> libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp
>>
>> libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp
>>     libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp
>>     libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp
>>     libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp
>>
>> Modified:
>> libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff
>>
>> ==============================================================================
>> ---
>> libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
>> (original)
>> +++
>> libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp
>> Thu Oct 23 16:17:36 2014
>> @@ -18,6 +18,11 @@
>>  //     has any difference from "C" collation.  But I do believe I'm
>> picking
>>  //     up the OS's collation files.
>>
>> +// TODO investigation needed.
>> +// Glibc seems to collate files differently from the way Apple's C
>> library does
>> +// it.
>> +// XFAIL: linux-gnu
>>
>
> Can you please just use "linux" here otherwise my openSUSE bots not
> picking it up apparently due to the vendor name.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141025/0be1b7eb/attachment.html>


More information about the cfe-commits mailing list