<div dir="ltr">I can't just use linux since these issues are related to GLIBC. Not all linux(es) use GLIBC. As danalbert mentioned during review that `linux` matches android as well.<div>Could you point me to your buildbot? I would like to look at the actual triple that is produced so I can see how to match it without catching android as well.</div><div><br></div><div>I will get it working on your buildbot, but I don't think just using `linux` will work.</div><div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 25, 2014 at 6:20 AM, İsmail Dönmez <span dir="ltr"><<a href="mailto:ismail@donmez.ws" target="_blank">ismail@donmez.ws</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Oct 24, 2014 at 12:17 AM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Thu Oct 23 16:17:36 2014<br>
New Revision: 220512<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=220512&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=220512&view=rev</a><br>
Log:<br>
[libcxx] XFAIL all currently failing libc++ tests for linux.<br>
<br>
Summary:<br>
Pretty please? We now have a significant number of builders that test libc++. I really want those builders to be green.<br>
Most of these failures are due to differences in locale data, including those in regex. I will continue working on fixing the locale and regex tests but there is no consensus on what the correct direction to go.<br>
<br>
Since the builders display a list of XFAIL tests they are by no means hidden. It just means they are expected failures. Now unexpected failures won't get mixed in with well known and expected failures.<br>
<br>
Reviewers: mclow.lists, jroelofs, danalbert<br>
<br>
Reviewed By: danalbert<br>
<br>
Subscribers: cfe-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D5941" target="_blank">http://reviews.llvm.org/D5941</a><br>
<br>
Modified:<br>
libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.get.byname/get_weekday_wide.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put.byname/put1.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp<br>
libcxx/trunk/test/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.match/basic.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.match/ecma.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.match/extended.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.search/awk.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.search/basic.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.search/ecma.pass.cpp<br>
libcxx/trunk/test/re/re.alg/re.alg.search/extended.pass.cpp<br>
libcxx/trunk/test/re/re.traits/lookup_collatename.pass.cpp<br>
libcxx/trunk/test/re/re.traits/translate_nocase.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp?rev=220512&r1=220511&r2=220512&view=diff</a><br>
==============================================================================<br>
--- libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp (original)<br>
+++ libcxx/trunk/test/localization/locale.categories/category.collate/locale.collate.byname/compare.pass.cpp Thu Oct 23 16:17:36 2014<br>
@@ -18,6 +18,11 @@<br>
// has any difference from "C" collation. But I do believe I'm picking<br>
// up the OS's collation files.<br>
<br>
+// TODO investigation needed.<br>
+// Glibc seems to collate files differently from the way Apple's C library does<br>
+// it.<br>
+// XFAIL: linux-gnu<br></blockquote><div><br></div></div></div><div>Can you please just use "linux" here otherwise my openSUSE bots not picking it up apparently due to the vendor name.</div></div></div></div>
</blockquote></div><br></div>