[PATCH] Supporting function-try-blocks for -Wreturn-type

David Blaikie dblaikie at gmail.com
Wed Oct 22 14:08:10 PDT 2014


On Wed, Oct 22, 2014 at 2:01 PM, Aaron Ballman <aaron at aaronballman.com>
wrote:

> On Wed, Oct 22, 2014 at 4:56 PM, David Blaikie <dblaikie at gmail.com> wrote:
> > Is a CompoundStatement's start/end loc ever different from lbrace/rbrace
> > location? (maybe when it's a compound statement without braces? But that
> can
> > never occur in this part of the AST, right)
>
> It appears to be possible because you can call setLBracLoc (thank
> goodness we left the "e" off there...), but that looks to only be
> called from ASTReader,
>
> > If it isn't, then the if/else
> > LBrace/RBrace bit could be omitted.
>
> There's no relationship between compound statements and function try
> block statements, so I'm not certain how we would omit the if/else.
>

Not sure I follow - but CompoundStmt and CXXTryStmt are both Stmts and all
Stmts have getLocStart/End, right? At least that's my theory...


>
> ~Aaron
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20141022/38e4736c/attachment.html>


More information about the cfe-commits mailing list