[clang-tools-extra] r218274 - Try to pacify dash-using linux distros with a very old-school shell variable compare.

[Alexander Kornienko]

On Mon, Sep 22, 2014 at 11:01 PM, Benjamin Kramer <benny.kra at googlemail.com>
wrote:

> Author: d0k
> Date: Mon Sep 22 16:01:04 2014
> New Revision: 218274
>
> URL: http://llvm.org/viewvc/llvm-project?rev=218274&view=rev
> Log:
> Try to pacify dash-using linux distros with a very old-school shell
> variable compare.
>
> While there fix the cmake shared build.
>
> Modified:
>     clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt
>     clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh
>
> Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=218274&r1=218273&r2=218274&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt (original)
> +++ clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Mon Sep 22
> 16:01:04 2014
> @@ -20,4 +20,5 @@ add_clang_library(clangTidyGoogleModule
>    clangBasic
>    clangLex
>    clangTidy
> +  clangTidyReadability
>    )
>
> Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh
> URL:
> http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=218274&r1=218273&r2=218274&view=diff
>
> ==============================================================================
> --- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh
> (original)
> +++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh Mon
> Sep 22 16:01:04 2014
> @@ -15,7 +15,7 @@ TEMPORARY_FILE=$3.cpp
>  # Feed the rest arguments to clang-tidy after --.
>  shift 3
>  CLANG_TIDY_ARGS=--std=c++11
> -if (($# > 0)) ; then
> +if [ "$#" -gt 0 ] ; then
>

Thanks! I was just trying to do a similar thing:

if [ -n "$1"] ; then
...



>    CLANG_TIDY_ARGS=$*
>  fi
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140922/12007e9a/attachment.html>