<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 22, 2014 at 11:01 PM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Mon Sep 22 16:01:04 2014<br>
New Revision: 218274<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=218274&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=218274&view=rev</a><br>
Log:<br>
Try to pacify dash-using linux distros with a very old-school shell variable compare.<br>
<br>
While there fix the cmake shared build.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt<br>
    clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
<br>
Modified: clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=218274&r1=218273&r2=218274&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt?rev=218274&r1=218273&r2=218274&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt (original)<br>
+++ clang-tools-extra/trunk/clang-tidy/google/CMakeLists.txt Mon Sep 22 16:01:04 2014<br>
@@ -20,4 +20,5 @@ add_clang_library(clangTidyGoogleModule<br>
   clangBasic<br>
   clangLex<br>
   clangTidy<br>
+  clangTidyReadability<br>
   )<br>
<br>
Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=218274&r1=218273&r2=218274&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh?rev=218274&r1=218273&r2=218274&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh (original)<br>
+++ clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy_fix.sh Mon Sep 22 16:01:04 2014<br>
@@ -15,7 +15,7 @@ TEMPORARY_FILE=$3.cpp<br>
 # Feed the rest arguments to clang-tidy after --.<br>
 shift 3<br>
 CLANG_TIDY_ARGS=--std=c++11<br>
-if (($# > 0)) ; then<br>
+if [ "$#" -gt 0 ] ; then<br></blockquote><div><br></div><div>Thanks! I was just trying to do a similar thing:</div></div></div><blockquote style="margin:0 0 0 40px;border:none;padding:0px"><div class="gmail_extra"><div class="gmail_quote"><div>if [ -n "$1"] ; then</div></div></div><div class="gmail_extra"><div class="gmail_quote"><div>...</div></div></div></blockquote><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   CLANG_TIDY_ARGS=$*<br>
 fi<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><div><br></div>
</div></div>