[PATCH] CodeGen: Give pointer parameters 'align' attributes
David Majnemer
david.majnemer at gmail.com
Thu Sep 18 15:13:24 PDT 2014
================
Comment at: lib/CodeGen/CGCall.cpp:1592
@@ -1591,1 +1591,3 @@
+ if (PVD->getType()->isAnyPointerType() ||
+ PVD->getType()->isReferenceType()) {
----------------
hfinkel wrote:
> I don't really know anything about ObjC, but just about all of the places in SemaDeclAttr that check for pointer types for relevant attributes check for:
> Ty->isAnyPointerType() || Ty->isBlockPointerType()
> So maybe you should check for block pointers too?
I don't know what the load alignment requirements are for block pointers. Omitting them is conservatively correct.
================
Comment at: lib/Headers/avxintrin.h:784
@@ -783,3 +783,3 @@
static __inline __m256d __attribute__((__always_inline__, __nodebug__))
-_mm256_loadu_pd(double const *__p)
+_mm256_loadu_pd(void const *__p)
{
----------------
hfinkel wrote:
> Are the changes to this file related to the alignment change?
Yes. These intrinsics are intended to be used with pointers with any alignment.
http://reviews.llvm.org/D5391
More information about the cfe-commits
mailing list