[PATCH] CodeGen: Give pointer parameters 'align' attributes

hfinkel at anl.gov hfinkel at anl.gov
Thu Sep 18 14:34:07 PDT 2014


================
Comment at: lib/CodeGen/CGCall.cpp:1592
@@ -1591,1 +1591,3 @@
 
+          if (PVD->getType()->isAnyPointerType() ||
+              PVD->getType()->isReferenceType()) {
----------------
I don't really know anything about ObjC, but just about all of the places in SemaDeclAttr that check for pointer types for relevant attributes check for:
  Ty->isAnyPointerType() || Ty->isBlockPointerType()
So maybe you should check for block pointers too?

================
Comment at: lib/Headers/avxintrin.h:784
@@ -783,3 +783,3 @@
 static __inline __m256d __attribute__((__always_inline__, __nodebug__))
-_mm256_loadu_pd(double const *__p)
+_mm256_loadu_pd(void const *__p)
 {
----------------
Are the changes to this file related to the alignment change?

http://reviews.llvm.org/D5391






More information about the cfe-commits mailing list