[libcxx] r217878 - Fix a bad noexcept clause in tuple's move constructor

Eric Fiselier eric at efcs.ca
Tue Sep 16 09:09:10 PDT 2014


I'm pretty sure this patch is not correct. I think this changes the
noexcept clause to check if a function of the form 'base(...)' Is nothrow
constructible.

Please let me know if I've missed anything.

/Eric
On Sep 16, 2014 9:48 AM, "Marshall Clow" <mclow.lists at gmail.com> wrote:

> Author: marshall
> Date: Tue Sep 16 10:36:14 2014
> New Revision: 217878
>
> URL: http://llvm.org/viewvc/llvm-project?rev=217878&view=rev
> Log:
> Fix a bad noexcept clause in tuple's move constructor
>
> Modified:
>     libcxx/trunk/include/tuple
>
> Modified: libcxx/trunk/include/tuple
> URL:
> http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/tuple?rev=217878&r1=217877&r2=217878&view=diff
>
> ==============================================================================
> --- libcxx/trunk/include/tuple (original)
> +++ libcxx/trunk/include/tuple Tue Sep 16 10:36:14 2014
> @@ -554,12 +554,12 @@ public:
>          _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX11
>          tuple(_Up&&... __u)
>              _NOEXCEPT_((
> -                is_nothrow_constructible<
> +                is_nothrow_constructible<base(
>                      typename __make_tuple_indices<sizeof...(_Up)>::type,
>                      typename __make_tuple_types<tuple,
> sizeof...(_Up)>::type,
>                      typename __make_tuple_indices<sizeof...(_Tp),
> sizeof...(_Up)>::type,
>                      typename __make_tuple_types<tuple, sizeof...(_Tp),
> sizeof...(_Up)>::type,
> -                    _Up...
> +                    _Up...)
>                  >::value
>              ))
>              : base_(typename __make_tuple_indices<sizeof...(_Up)>::type(),
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140916/d22362f0/attachment.html>


More information about the cfe-commits mailing list