<p dir="ltr">I'm pretty sure this patch is not correct. I think this changes the noexcept clause to check if a function of the form 'base(...)' Is nothrow constructible.</p>
<p dir="ltr">Please let me know if I've missed anything.</p>
<p dir="ltr">/Eric</p>
<div class="gmail_quote">On Sep 16, 2014 9:48 AM, "Marshall Clow" <<a href="mailto:mclow.lists@gmail.com">mclow.lists@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: marshall<br>
Date: Tue Sep 16 10:36:14 2014<br>
New Revision: 217878<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217878&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217878&view=rev</a><br>
Log:<br>
Fix a bad noexcept clause in tuple's move constructor<br>
<br>
Modified:<br>
    libcxx/trunk/include/tuple<br>
<br>
Modified: libcxx/trunk/include/tuple<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/tuple?rev=217878&r1=217877&r2=217878&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/tuple?rev=217878&r1=217877&r2=217878&view=diff</a><br>
==============================================================================<br>
--- libcxx/trunk/include/tuple (original)<br>
+++ libcxx/trunk/include/tuple Tue Sep 16 10:36:14 2014<br>
@@ -554,12 +554,12 @@ public:<br>
         _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX11<br>
         tuple(_Up&&... __u)<br>
             _NOEXCEPT_((<br>
-                is_nothrow_constructible<<br>
+                is_nothrow_constructible<base(<br>
                     typename __make_tuple_indices<sizeof...(_Up)>::type,<br>
                     typename __make_tuple_types<tuple, sizeof...(_Up)>::type,<br>
                     typename __make_tuple_indices<sizeof...(_Tp), sizeof...(_Up)>::type,<br>
                     typename __make_tuple_types<tuple, sizeof...(_Tp), sizeof...(_Up)>::type,<br>
-                    _Up...<br>
+                    _Up...)<br>
                 >::value<br>
             ))<br>
             : base_(typename __make_tuple_indices<sizeof...(_Up)>::type(),<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div>