PATCH: ASTMatcher for CUDA declarations

[Jacques Pienaar]

Good point :) Added a negative test for matchesWithCuda and
notMatchesWithCuda. And will use phab in future.


On Mon, Aug 4, 2014 at 4:35 AM, Manuel Klimek <klimek at google.com> wrote:

> On Mon, Aug 4, 2014 at 1:34 PM, Manuel Klimek <klimek at google.com> wrote:
>
>> On Fri, Aug 1, 2014 at 7:43 PM, Jacques Pienaar <jpienaar at google.com>
>> wrote:
>>
>>> Hi,
>>>
>>> The patch adds ASTMatchers for matching CUDA declarations.
>>>
>>> Kindly asking for review.
>>>
>>
>> (just for the future: it'll make it easier for me to review if you run it
>> through phab - this change is small enough that it doesn't make a big
>> difference though)
>>
>> Can you please run:
>> $ cd tools/clang/docs/tools
>> $ python ./dump_ast_matchers.py
>> (this will automatically update the documentation)
>>
>
> Also, you might want to add a reverse test (otherwise we have a) code
> that's not executed and b) we could implement matchesWithCuda as "return
> true" :)
>
>>
>>
>>>
>>> Jacques
>>>
>>> --
>>> Jacques Pienaar | Platforms | jpienaar at google.com | 765-430-6883
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>
>>>
>>
>


-- 
Jacques Pienaar | Platforms | jpienaar at google.com | 765-430-6883
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140804/f26dffee/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CudaMatchers.patch
Type: text/x-patch
Size: 17744 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140804/f26dffee/attachment.bin>