PATCH: ASTMatcher for CUDA declarations

Manuel Klimek klimek at google.com
Mon Aug 4 04:35:09 PDT 2014


On Mon, Aug 4, 2014 at 1:34 PM, Manuel Klimek <klimek at google.com> wrote:

> On Fri, Aug 1, 2014 at 7:43 PM, Jacques Pienaar <jpienaar at google.com>
> wrote:
>
>> Hi,
>>
>> The patch adds ASTMatchers for matching CUDA declarations.
>>
>> Kindly asking for review.
>>
>
> (just for the future: it'll make it easier for me to review if you run it
> through phab - this change is small enough that it doesn't make a big
> difference though)
>
> Can you please run:
> $ cd tools/clang/docs/tools
> $ python ./dump_ast_matchers.py
> (this will automatically update the documentation)
>

Also, you might want to add a reverse test (otherwise we have a) code
that's not executed and b) we could implement matchesWithCuda as "return
true" :)

>
>
>>
>> Jacques
>>
>> --
>> Jacques Pienaar | Platforms | jpienaar at google.com | 765-430-6883
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140804/f720d792/attachment.html>


More information about the cfe-commits mailing list