r213171 - Make clang's rewrite engine a core feature

[Richard Smith]

On Wed, Jul 16, 2014 at 8:07 PM, Alp Toker <alp at nuanti.com> wrote:

>  My reply here was me taking my earliest opportunity to engage and
>> discuss. =)
>>
>
> I don't understand your sudden expectation to be copied into the
> discussion here. It's a module you haven't committed to at all recently or
> as far back as I can remember. I've been relatively active in this corner
> of the codebase and the change was discussed and approved on the commits
> list.
>

There were two changes here. One (the file reorganization) was not
discussed and not approved. For the other, only two hours passed between
the first suggestion of the change and the commit, the discussion happened
on an unrelated patch review thread, and it removed a supported
configuration option. The level and duration of preceding discussion was
not sufficient for either of these changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140716/78dc28d9/attachment.html>