[PATCH] Driver: bifurcate extended and basic MSC versioning

[Saleem Abdulrasool]

On Jul 1, 2014, at 1:07 PM, Aaron Ballman <aaron.ballman at gmail.com> wrote:

> On Tue, Jul 1, 2014 at 3:57 PM, Reid Kleckner <rnk at google.com> wrote:
>> On Tue, Jul 1, 2014 at 12:52 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>>> 
>>> I think Alp is refering to _MSC_FULL_VER from here:
>>> https://urldefense.proofpoint.com/v1/url?u=http://msdn.microsoft.com/en-us/library/b0084kay.aspx&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=CchYc4lrV44%2BZqxZADw0BQ%3D%3D%0A&m=kB4S02RYsGqzRU%2B%2FmKnb%2FHDPgdUp40KkZM1ldXPnqYg%3D%0A&s=bcc734f8e8861ffd021dadefa5b99d8aae60b53b3a4ef44247b4d19f1b0cb045
>>> 
>>> That said, I'm not sure this option is a perfect representation of that
>>> symbol.
>>> 
>>> I don't like "extended version" either, so I'm going out on a limb:
>>> -fmsc-version-string?
> 
> If it required quotes, like -fmsc-version-string="17.00" that might be
> reasonable.

I like this option as well.  Note that the quoting, at least in Unix land is only required when there are spaces to indicate that the string contains the space (you may optionally quote the space with the quote character ‘\’).  So, not requiring the quotes seems fine to me.

>> -fmsc-dotted-version?
> 
> That's an interesting choice.
> 
> Another idea: -fmsc-compiler-version?
> 
> (It's a shame we cannot make this work using just -fmsc-version...)
> 
> ~Aaron
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> https://urldefense.proofpoint.com/v1/url?u=http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=CchYc4lrV44%2BZqxZADw0BQ%3D%3D%0A&m=kB4S02RYsGqzRU%2B%2FmKnb%2FHDPgdUp40KkZM1ldXPnqYg%3D%0A&s=7cff80696d1ff391dba43bd1ca9f79d80e2cb773f64618c92a348a6831b30fde

-- 
Saleem Abdulrasool
abdulras (at) fb (dot) com